Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Add @throws ConnectionException tag on Http methods for IDE support #51066

Merged
merged 4 commits into from
Apr 15, 2024
Merged

[11.x] Add @throws ConnectionException tag on Http methods for IDE support #51066

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0894ff8
feat: add docblock on http methods
Apr 15, 2024
a6fee60
feat: use only ConnectionException
Apr 15, 2024
fef96c3
feat: use FQN
Apr 15, 2024
685d864
feat: use FQN
Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Illuminate/Http/Client/PendingRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,8 @@ public function dd()
* @param string $url
* @param array|string|null $query
* @return \Illuminate\Http\Client\Response
*
* @throws ConnectionException|\Throwable
driesvints marked this conversation as resolved.
Show resolved Hide resolved
*/
public function get(string $url, $query = null)
{
Expand All @@ -778,6 +780,8 @@ public function get(string $url, $query = null)
* @param string $url
* @param array|string|null $query
* @return \Illuminate\Http\Client\Response
*
* @throws ConnectionException|\Throwable
*/
public function head(string $url, $query = null)
{
Expand All @@ -792,6 +796,8 @@ public function head(string $url, $query = null)
* @param string $url
* @param array $data
* @return \Illuminate\Http\Client\Response
*
* @throws ConnectionException|\Throwable
*/
public function post(string $url, $data = [])
{
Expand All @@ -806,6 +812,8 @@ public function post(string $url, $data = [])
* @param string $url
* @param array $data
* @return \Illuminate\Http\Client\Response
*
* @throws ConnectionException|\Throwable
*/
public function patch(string $url, $data = [])
{
Expand All @@ -820,6 +828,8 @@ public function patch(string $url, $data = [])
* @param string $url
* @param array $data
* @return \Illuminate\Http\Client\Response
*
* @throws ConnectionException|\Throwable
*/
public function put(string $url, $data = [])
{
Expand All @@ -834,6 +844,8 @@ public function put(string $url, $data = [])
* @param string $url
* @param array $data
* @return \Illuminate\Http\Client\Response
*
* @throws ConnectionException|\Throwable
*/
public function delete(string $url, $data = [])
{
Expand Down Expand Up @@ -869,7 +881,7 @@ public function pool(callable $callback)
* @param array $options
* @return \Illuminate\Http\Client\Response
*
* @throws \Exception
* @throws ConnectionException|\Exception|\Throwable
*/
public function send(string $method, string $url, array $options = [])
{
Expand Down