[11.x] Add @throws ConnectionException tag on Http methods for IDE support #51066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
changed the title
driesvints
requested changes
Apr 15, 2024
|
this EncrypterTest::testRawStringEncryptionWithPreviousKeys test is failed that not related to my PR |
added 2 commits
April 15, 2024 14:12
driesvints
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request just adds the @throws ConnectionException tag to the head, get, post, put, patch, and delete methods on the HTTP class for support IDE suggestion.
if only use this method after the facade i.e.
Http::post()IDE can't suggest but if used after any other method such asasJson()IDE can suggest exceptions and developers notice that this method throws exceptions.Some time ago in my company Due to not being aware of this exception, we encountered an error due to a connection error and there is no complete explanation about this exception in the Laravel documentation.