Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Deprecate old collection and macroable objects #32481

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

driesvints
Copy link
Member

We should definitely keep the objects around for a couple of major versions but we should push people to use the newer classes so we can eventually get rid of the duplicate ones.

@taylorotwell taylorotwell merged commit a6820ee into master Apr 21, 2020
@driesvints driesvints deleted the deprecate-old-classes branch April 21, 2020 18:18
@crynobone
Copy link
Member

I find it odd that Illuminate\Collections\Enumerable and Illuminate\Collections\EnumerableValues contract extends Illuminate\Contracts\Support\Arrayable and Illuminate\Contracts\Support\Jsonable.

Would it make send to explicitly have this been used by Illuminate\Support\Collection and Illuminate\Support\LazyCollection and keep them for framework usage.

@driesvints
Copy link
Member Author

@crynobone agreed. I'll send in a pr.

@driesvints
Copy link
Member Author

@crynobone actually, I meant that I think it's also odd that the contract extends from these but I feel like the collection classes themselves can definitely keep them.

@driesvints
Copy link
Member Author

@crynobone #32506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants