-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Split Collections Into A Separate Package #32478
Conversation
Yesssssssssss I am so happy! |
YYOOOOOUUUUHHOOOUUU! 🎉 thx @regiszanandrea for the ping! (After several years trying to push that, it only needed one tweet to @driesvints to got it! 🤣) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to find something, but actually everything sounds good to me. 👍🏻
Nice |
Is the plan to remove the extended classes in the future? So there is no duplicate Collection and Macroable classes? |
@olivernybroe while technically yes I think it could be a year or two (or more) away. There is no maintenance overhead for us keeping them and it only inflicts pain on users by removing them. |
Nice! Any chance that pagination could be added in now? A lot of love for this out there still: https://gist.github.com/simonhamp/549e8821946e2c40a617c85d2cf5af5e |
This PR splits collections into a separate package while remaining backward compatible with older releases of Laravel.
This also necessitated the creation of a new
illuminate/macroable
package.The
Illuminate\Support
collection classes were left in place and simply extend the newIlluminate\Collections
classes where appropriate and override a few construction methods that use theself
keyword. TheIlluminate\Support\Arr
class was treated the same way.No existing tests needed to be changed.