Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Split Collections Into A Separate Package #32478

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Conversation

taylorotwell
Copy link
Member

@taylorotwell taylorotwell commented Apr 21, 2020

This PR splits collections into a separate package while remaining backward compatible with older releases of Laravel.

This also necessitated the creation of a new illuminate/macroable package.

The Illuminate\Support collection classes were left in place and simply extend the new Illuminate\Collections classes where appropriate and override a few construction methods that use the self keyword. The Illuminate\Support\Arr class was treated the same way.

No existing tests needed to be changed.

@regiszanandrea
Copy link
Contributor

@mathieutu #25421

@GrahamCampbell GrahamCampbell changed the title Split Collections Into A Separate Package [8.x] Split Collections Into A Separate Package Apr 21, 2020
@mattstauffer
Copy link
Contributor

Yesssssssssss I am so happy!

@mathieutu
Copy link
Contributor

YYOOOOOUUUUHHOOOUUU! 🎉

thx @regiszanandrea for the ping!

(After several years trying to push that, it only needed one tweet to @driesvints to got it! 🤣)

Copy link
Member

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to find something, but actually everything sounds good to me. 👍🏻

@taylorotwell taylorotwell merged commit ddddd0c into master Apr 21, 2020
@xuandung38
Copy link

Nice

@driesvints driesvints deleted the collections branch April 21, 2020 18:04
@olivernybroe
Copy link
Contributor

Is the plan to remove the extended classes in the future? So there is no duplicate Collection and Macroable classes?

@driesvints
Copy link
Member

@olivernybroe #32481

@taylorotwell
Copy link
Member Author

taylorotwell commented Apr 21, 2020

@olivernybroe while technically yes I think it could be a year or two (or more) away. There is no maintenance overhead for us keeping them and it only inflicts pain on users by removing them.

@simonhamp
Copy link
Contributor

Nice! Any chance that pagination could be added in now? A lot of love for this out there still: https://gist.github.com/simonhamp/549e8821946e2c40a617c85d2cf5af5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants