[5.7] Allow TransportManager to create log driver with any Psr\Log\LoggerInterface instance #26842
Conversation
|
@driesvints would it be better to wrap the conditional in an |
|
@sebdesign yeah I agree. |
driesvints
changed the title
|
@sebdesign I also think it's best to explain in your main comment why you're sending this in. It helps Taylor to understand clearly why this change is needed. |
|
Could also use a failing test for the problem at hand. |
|
@driesvints When I implemented this feature I had a test that asserted the TransportManager would have the default log channel, but Taylor removed it, so I thought it would be useless to add a similar test again. But I can definitely add a failing test. Should I push it here since this PR has already been merged? I'm sorry for the poor commit message though. |
|
@sebdesign you can send in a new PR for that :) |
…ce instance In addition to laravel#26842, this test asserts that the `TransportManager` can create a log driver when the application has a different implementation of the `Psr\Log\LoggerInterface`, e.g. when the `illuminate/mail` package is used outside of Laravel.
…ce instance In addition to laravel#26842, this test asserts that the `TransportManager` can create a log driver when the application has a different implementation of the `Psr\Log\LoggerInterface`, e.g. when the `illuminate/mail` package is used outside of Laravel.
Addresses #26833