illuminate/laravel 5.7

[luceos]

Fixes #1640

Changes proposed in this pull request:

• Upgrade to Illuminate 5.7
• Make Gates compliant to contract

Reviewers should focus on:

• Do we want to keep using the Gate contract, from looking at User\Gate I see a bunch of unused methods which make using the interface pretty much useless.
• Blocked by Using illuminate/mail outside of Laravel with driver log breaks laravel/framework#26833

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run php vendor/bin/phpunit).

Required changes:

• Related documentation PR: (Remove if irrelevant)
• Related core extension PRs: (Remove if irrelevant)

[franzliedke]

I guess we don't really need the manager class anyway, we can just instantiate the log driver we want to use manually.

[tobyzerner]

Do we want to keep using the Gate contract, from looking at User\Gate I see a bunch of unused methods which make using the interface pretty much useless.

We will revamp the authorisation code separately soon, but for now this is fine :)

Are there any other changes required?

[luceos]

Not sure yet. I like to run these changes with a working test suite.

@franzliedke the problem is that our tests use the Mail driver log which resolves LoggerInterface from the container. This interface is bound to our Monolog logger and not the Logging Transport manager as Laravel assumes.

Some of our options:

• Rewrite tests to not use the mail driver log and optionally disallow people from using it in Flarum.
• Wait for the changes to be released under 5.7.18, [5.7] Allow TransportManager to create log driver with any Psr\Log\LoggerInterface instance laravel/framework#26842

[tobyzerner]

Let's wait, no rush to get this merged

[luceos]

5.7.18 and .19 are tagged, moving forward.

[luceos]

Final decision has to be made about the Gate contract and or User/Gate implementation, it now has 5 methods which are not implemented.

Everything else seems 👍 good to go.

[franzliedke]

Final decision has to be made about the Gate contract and or User/Gate implementation, it now has 5 methods which are not implemented.

If I understood Toby right, he wants to take care of revamping Gate and other authentication stuff later, so just adding the empty stub is fine.

[franzliedke]

Thanks for taking care of this. 👍