[5.4] Fixed Validator failing on 'before_or_equal:today' for today's date

[pantherdd]

Fixed Validator failing on 'before_or_equal:today' when the input is today's date and a format is specified

The issue was that the time part was bleeding through from the current timestamp in DateTime::createFromFormat.

Test case:

• Validation rule: 'birth_date' => ['required', 'date_format:Y-m-d', 'before_or_equal:today']
• '2017-08-27' was parsed as '2017-08-27 22:41:37'.
• 'today' was parsed as '2017-08-27 00:00:00'.
• Validation failed.

[arjasco]

Nice.

I hope this gets merged as it fixes the problem i described in my comment on this PR: #20566 if it doesn't looks like 5.5 will have the same problem.

This must be wide issue that I'm surprised isn't spoken about more. I submitted a PR back in January, implementing pretty much exactly what you have got closed. It's a PHP internal thing that needs fixing..

Seeing as this problem occurs in certain months, writing a test is a bit pointless cause it would pass anyway till the day in the month it occurs comes around... So this seems the best solution to me cause it doesn't affect anything apart from giving you the correct date to compare against which is what the the tests are checking for anyway.

[taylorotwell]

Isn't this going to break applications? What if people want the time part?

[pantherdd]

@taylorotwell If you have time fields in the date format, it will still use them...

http://php.net/manual/en/datetime.createfromformat.php

If format contains the character !, then portions of the generated time not provided in format, as well as values to the left-hand side of the !, will be set to corresponding values from the Unix epoch.

>>> DateTime::createFromFormat('!Y-m-d H:i:s', '2017-08-28 18:57:24')
=> DateTime {#890
     +"date": "2017-08-28 18:57:24.000000",
     +"timezone_type": 3,
     +"timezone": "Europe/Paris",
   }

Please re-open this (or at least show a test case that this change breaks).

(You could've given me some time to reply to your question before closing the PR...)

[pantherdd]

@arjasco Thanks for the links.

Further information I found:

• [5.4] Validation Rule: date_format bug #17642 is the issue that has re-surfaced here, and what this PR would fix for good.
• [5.4] Validation Rule: date_format bug #17642 (comment) describes the reason why I can't use a format with a ! prepended.
• #17642 - Reset day parameter when using Y-m #20566 is just a one-off workaround for a single specific date format, and even for that format, it doesn't support 'before' and 'after' rules.

[pantherdd]

@taylorotwell I added a number of date validation tests in a second commit. These tests deal with the time parts, and show that the fix I made is not breaking anything.

Unfortunately, that second commit is not picked up by this PR, probably because it is closed. Here is a complete diff: 5.4...PantherDD:fix-validator-date-format .