-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[5.5] Fixed date comparison validators failing when a format is speci…
…fied (#20940) * Fixed Validator failing on 'before_or_equal:today' when the input is today's date and a format is specified The issue was that the time part was bleeding through from the current timestamp in `DateTime::createFromFormat`. Test case: * Validation rule: 'birth_date' => ['required', 'date_format:Y-m-d', 'before_or_equal:today'] * '2017-08-27' was parsed as '2017-08-27 22:41:37'. * 'today' was parsed as '2017-08-27 00:00:00'. * Validation failed. * Added date validator tests for time fields This shows that the fix in 1b651e6 is not going to break applications, people can still use the time part. This should address the comment of @taylorotwell at #20789 . * Fixed Validator failing on 'date_equals' when a format is specified Also added a number of test cases. The issue was that `===` always returns false for the two separate DateTime instances returned by `getDateTimeWithOptionalFormat`.
- Loading branch information
1 parent
866e465
commit 48f4f0c
Showing
2 changed files
with
174 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters