[5.4] Attempt to fix container bug

[laurencei]

This is an attempt to fix the bug introduced in 5.4.16 as described in #18806

From my testing - it looks when resolving a singleton, the collection never pops the $this->make[] array - resulting in additional new arrays being constantly added to the existing array every time a call to resolve() occurs. Because these new arrays are never released when resolving a singleton - it results in the run away memory usage.

This is particularly noticeable in an Eloquent object, where calls that include date attribute casting can easily result in thousands of calls to resolve() - which keeps adding arrays to $this->make[], and never pops them off when finished.

My testing shows memory returns to the same as 5.4.15 with this PR.

My major concern; is there another effect on the container this PR might have that I'm not considering? Especially for the makeWith() functions?

I ran through the container code - and I dont believe $this->with is ever touched until after the container confirms it is not resolving something that is already resolved as a singleton. So by moving it down until after the singleton test, we remove the increased memory usage...

[rimace]

This fixed the increased memory usage bug, thanks.

[taylorotwell]

We have tests for makeWith so if they pass it's probably fine.