Skip to content

Commit

Permalink
[5.4] Attempt to fix container bug (#18812)
Browse files Browse the repository at this point in the history
* first attempt

* keep StyleCI happy

* delay retrieving parameters
  • Loading branch information
laurencei authored and taylorotwell committed Apr 16, 2017
1 parent e1fc1fa commit ebe568c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Illuminate/Container/Container.php
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,6 @@ public function make($abstract)
*/
protected function resolve($abstract, $parameters = [])
{
$this->with[] = $parameters;

$needsContextualBuild = ! empty($parameters) || ! is_null(
$this->getContextualConcrete($abstract = $this->getAlias($abstract))
);
Expand All @@ -589,6 +587,8 @@ protected function resolve($abstract, $parameters = [])
return $this->instances[$abstract];
}

$this->with[] = $parameters;

$concrete = $this->getConcrete($abstract);

// We're ready to instantiate an instance of the concrete type registered for
Expand Down

0 comments on commit ebe568c

Please sign in to comment.