New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Fix eager load on belongsTo when ID is 0 #17667

Closed

fernandobandeira wants to merge 3 commits into laravel:5.4 from fernandobandeira:5.4

Contributor

fernandobandeira commented Jan 30, 2017 •

edited

Loading

Since array_filter by default removes elements which are equal to 0, when having a record with and ID = 0 the eager load won't work properly.

This was proposed on #17653
But this solution doesn't modify the filter method, just call it with a callback instead...

Ping @antonioribeiro

fernandobandeira and others added 3 commits

January 30, 2017 11:13


          Fix belongsTo Eagerload when ID == 0

32e7bd6


          StyleCI

7cc4bcf


          Chaging name order...

0dc7ad4

Contributor Author

fernandobandeira commented Jan 30, 2017

Closed for #17668

fernandobandeira closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet