Fix Collections's filter() discarding values == 0 #17653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is meant to behave like array_filter, which filters 0s. |
|
So the bug in BelongsTo stays? |
|
Meaning we cannot have an ID == 0 in our tables? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BelongsTo is not able to eager load relations when the
id == 0. In my opinion$collection->filter()should not discard zeroes at all, only nulls, booleans (false) and empty strings (''). And maybe not even booleans, becausefalseis also a value ([something_is_enabled => false]), but that's something we can probably filter using a closure.This is a bug introduced in 5.4.