Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration doesn't account for prefix when checking if migration table exists [bug] #3

Closed
fideloper opened this issue Jan 11, 2013 · 3 comments
Closed

Migration doesn't account for prefix when checking if migration table exists [bug] #3

fideloper opened this issue Jan 11, 2013 · 3 comments
Labels
bug

Comments

@fideloper
Copy link
Contributor

Original bug found here: https://github.com/illuminate/database/issues/111 - Moved to his repo as per Taylor. Here's the original text:

I spoke with Machuga in IRC - It was suggested I create an issue.

Issue:

Error after first migration: SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'up_migrations' already exists

Steps to reproduce:

  1. Fresh install of L4
  2. Add a prefix to database in database connection config (MySql)
  3. Create a migration $ php artisan migrate:make create_users_table --table=users --create
  4. Fill in some fields, run the migration $ php artisan migrate
  5. Attempt a migrate:refresh $ php artisan migrate:refresh
  6. ERROR: SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'up_migrations' already exists

Relevant files:

I tracked this down to this file: Illuminate\Database\MigrationsDatabaseMigrationRepository::repositoryExists() and specifically within that, the call to return $schema->hasTable($this->table); here

The $this->table variable passed to hasTable() does not include the table prefix. Illuminate\Database\Schema\MySqlBuilder::hasTable($table) does not check for prefix either.

Unfortunately I'm not yet familiar with the code/convention to know where you'd prefer to look up the prefix. (Not sure what class should have that "knowledge")
@taylorotwell
Copy link
Member

OK, Thanks. We'll get it fixed.

@taylorotwell
Copy link
Member

Fixed.

@johnnncodes johnnncodes mentioned this issue Jan 26, 2013
Closed
@Darksoulsong
Copy link

I´m having this very same issue and I just downloaded the framework from the site.
I wonder if the fix was commited to the site version.

@maximebeaudoin maximebeaudoin mentioned this issue Apr 30, 2013
Closed
@crissi crissi mentioned this issue Jul 25, 2013
Closed
@crynobone crynobone mentioned this issue Jul 26, 2013
Closed
@ashmenon ashmenon mentioned this issue Aug 7, 2013
Closed
@fturmel fturmel mentioned this issue Sep 13, 2013
Closed
@antonioribeiro antonioribeiro mentioned this issue Dec 8, 2013
Closed
@ghost ghost mentioned this issue Jan 12, 2014
Closed
@nolros nolros mentioned this issue May 27, 2014
Closed
@ghost ghost mentioned this issue Jun 15, 2014
Closed
@bachmacintosh bachmacintosh mentioned this issue Oct 9, 2014
Closed
@danwdart danwdart mentioned this issue Oct 17, 2014
Closed
@szabizs szabizs mentioned this issue Nov 9, 2014
Closed
@jataggart jataggart mentioned this issue Nov 10, 2014
Closed
@jonathanpmartins jonathanpmartins mentioned this issue Nov 15, 2014
Closed
@wesleywillians wesleywillians mentioned this issue Nov 19, 2014
Closed
@ash-rain ash-rain mentioned this issue Dec 8, 2014
Closed
@ahmed609 ahmed609 mentioned this issue Dec 29, 2014
Closed
@ivaaaan ivaaaan mentioned this issue Jan 22, 2015
Closed
@Marwelln Marwelln mentioned this issue Feb 23, 2015
Closed
@jason-chang jason-chang mentioned this issue Jul 7, 2015
Closed
@Codenator81 Codenator81 mentioned this issue Jul 16, 2015
Closed
KluVerKamp added a commit to KluVerKamp/framework that referenced this issue Aug 29, 2015
@KluVerKamp
[5.1] Decrypting cookies encrypted with a different Cipher
bf61d04 
Lately, I have upgraded my website from L 4.2.11 to the latest one. The Encryption cipher used before was MCRYPT_RIJNDAEL_128 which uses an IV with a length of 32. Since the payload in the cookies in users was encrypted using the old cipher, the EncryptCookies middleware threw an exception with this trace:

```
production.ERROR: exception 'ErrorException' with message 'openssl_decrypt(): IV passed is 32 bytes long which is longer than the 16 expected by selected cipher, truncating' in /home/www/MY/vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php:95
Stack trace:
#0 [internal function]: Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(2, 'openssl_decrypt...', '/home/www/...', 95, Array)
laravel#1 /home/www/MY/vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php(95): openssl_decrypt('Dbyr0401XlXcY6N...', 'AES-256-CBC', 'VyZn2WxfW9UgMrI...', 0, 'h\x82\x9Co\t\x9Fqx\\\x84\x8B\x16\x8B\x82P...')
laravel#2 /home/www/MY/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(95): Illuminate\Encryption\Encrypter->decrypt('eyJpdiI6ImFJS2N...')
laravel#3 /home/www/MY/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(76): Illuminate\Cookie\Middleware\EncryptCookies->decryptCookie('eyJpdiI6ImFJS2N...')
laravel#4 /home/www/MY/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(59): Illuminate\Cookie\Middleware\EncryptCookies->decrypt(Object(Illuminate\Http\Request))
laravel#5 [internal function]: Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure))
laravel#6 /home/www/MY/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(124): call_user_func_array(Array, Array)
laravel#7 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
laravel#8 /home/www/MY/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
laravel#9 /home/www/MY/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(122): Illuminate\Pipeline\Pipeline->then(Object(Closure))
laravel#10 /home/www/MY/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(87): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
laravel#11 /home/www/MY/public/index.php(54): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
laravel#12 {main} 
```
This commit will allow the the decrypt method to handle non `Illuminate\Contracts\Encryption\DecryptException` exceptions. Since sometimes that class can't cover all the decryption issues since cookies can be set from other third parties in the browser.
@kneipp kneipp mentioned this issue Sep 28, 2015
Closed
@ajeeeunni ajeeeunni mentioned this issue Oct 31, 2015
Closed
@cvlug cvlug mentioned this issue Nov 25, 2015
Closed
@viniciusstroff viniciusstroff mentioned this issue May 25, 2021
Closed
@mcastania mcastania mentioned this issue Sep 5, 2021
Closed
@fazlur10 fazlur10 mentioned this issue Sep 14, 2021
Closed
@Faks Faks mentioned this issue Nov 9, 2021
Closed
@krixnaas krixnaas mentioned this issue Feb 9, 2022
Closed
@karimnaimy karimnaimy mentioned this issue Feb 9, 2022
Closed
@aherrao aherrao mentioned this issue Apr 6, 2022
Closed
@Levivb Levivb mentioned this issue Apr 7, 2022
Closed
@sayemk sayemk mentioned this issue May 25, 2022
Closed
@LiXunGuan LiXunGuan mentioned this issue Jun 3, 2022
Closed
@sblindt sblindt mentioned this issue Jun 7, 2022
Closed
@HthSolid HthSolid mentioned this issue Jun 27, 2022
Closed
@crynobone crynobone mentioned this issue Dec 15, 2022
Merged
@taylorotwell taylorotwell mentioned this issue Jan 4, 2023
Merged
@ranbahar ranbahar mentioned this issue Jan 5, 2023
Closed
@some0ne2 some0ne2 mentioned this issue Jan 9, 2023
Closed
@Faks Faks mentioned this issue Feb 18, 2023
Closed
christoph-kluge added a commit to christoph-kluge/framework that referenced this issue Apr 22, 2023
@christoph-kluge
Make style ci happy - Round laravel#3
24a8f20
maddios pushed a commit to maddios/framework that referenced this issue Jul 13, 2023
@paulrblakey
Merge pull request laravel#3 from maddios/patch-2
5115957 
added connectionName to queryLog
@emireadcode emireadcode mentioned this issue Aug 19, 2023
Closed
@khaledHAssi khaledHAssi mentioned this issue Aug 30, 2023
Closed
@davidniechoj davidniechoj mentioned this issue Oct 10, 2023
Closed
gonzalom pushed a commit to Hydrane/tmp-laravel-framework that referenced this issue Oct 12, 2023
@taylorotwell
Merge pull request laravel#3 from crynobone/feature/support-dev
ef6f04c 
Allow Lumen 5.1 to be installed.
gonzalom pushed a commit to Hydrane/tmp-laravel-framework that referenced this issue Oct 12, 2023
@jensdenies
Merge pull request laravel#3 from laravel/5.7
d5f0b27 
Merge
@crynobone crynobone mentioned this issue Oct 20, 2023
Closed
@bernardwiesner bernardwiesner mentioned this issue Oct 24, 2023
Closed
@fntneves fntneves mentioned this issue Oct 29, 2023
Merged
@kindslayer kindslayer mentioned this issue Mar 14, 2024
Closed
@streamingsystems streamingsystems mentioned this issue Jun 6, 2024
Closed
@arborrow arborrow mentioned this issue Sep 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@taylorotwell @fideloper @Darksoulsong