[5.0] Allow composer require illuminate/routing without extra illuminate/events #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are trying to use `illuminate/routing`, we are required to manually require `illuminate/events` as it's used in the [`__construct`](https://github.com/laravel/framework/blob/5.0/src/Illuminate/Routing/Router.php#L110) method of `Illuminate\Routing\Router.php`. This change will allow us to only require `illuminate/routing` if we want to use the routing system without the main Laravel framework.
Marwelln
changed the title
|
Not it's not. We're asking for a contract. Please could you add this to the suggested dependencies list though, in the same format we do for the other suggestions in packages. |
|
@GrahamCampbell but it would be useful if we can suggest an implementation using composer suggest. |
|
@crynobone That's what I meant when I said:
|
|
@GrahanCampbell missed that. @Marwelln service provider are designed to be use in Laravel. For external project you should manage configuring the service on your own, which include setting up an implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are trying to use
illuminate/routing, we are required to manually requireilluminate/eventsas it's used in the__constructmethod ofIlluminate\Routing\Router.php. This change will allow us to only requireilluminate/routingif we want to use the routing system without the main Laravel framework.