Add Support for ULID column type #657
Conversation
…odel feat: add hasuuids trait to model
…odel test: add tests for hasuuids trait
The change updates the regular expression in Blueprint.php to match 'ulid' and 'uuid' both. The update will reflect in the functionality where these matches are used for id creation.
A ULID shorthand has been introduced to the MigrationGeneratorTest, allowing ULID fields to be easily added through drafts. This is captured in new tests and the corresponding fixture files, validating its successful integration.
ULID column type has been added to the FactoryGenerator and corresponding tests. This update augments the list of column data types that can be used, particularly aiding situations where a universally unique lexicographically sortable identifier (ULID) is required. Test fixtures are updated to validate this new addition.
The ULID column type has been added to the 'all-column-types' test fixture.
Two new files were created to handle the case of a ulid shorthand with an invalid relationship. This includes a test case in the MigrationGeneratorTest.php file and a matching migration file. A draft file for ulid-shorthand-invalid-relationship was also added to the fixtures folder.
A new test for the case of a ULID without a relationship was added in MigrationGeneratorTest.php file. Along with this, corresponding migration and draft files were created under the fixtures directory. This update aids in handling scenarios with ULID that do not have any specified relationships.
'ulidMorphs' was added to the test fixtures in all-column-types for drafts, models, and factories.
Foreign key constraints updated in model test fixtures and new foreign keys 'customer_id' and 'tran_id' added. Migration Generator has been modified to handle ULID datatype along with ID and UUID. This commit adapts the Migration Generator to recognize and handle the ULID datatype and updates tests to reflect this change.
A new function, `it_parses_ulid_shorthand`, is added to BlueprintTest to ensure correct parsing of ULID shorthand. Accordingly, assertions have also been updated to reflect this new generation method in the relevant test fixtures and new keys handling.
The `nullableUlidMorphs` and `ulidMorphs` column types have been added to the `all-column-types` test fixtures and model generator. The appropriate handling for these new column types were added to the `ModelGenerator` PHP class. This addition ensures that these column types are properly processed and reflected in the models.
Added a function to check if ULIDs are used in the 'Model' class. Expanded 'ModelGenerator' class to act accordingly if ULIDs are used. Added respective test case and fixture files to ensure correct functionality.
Added a function to check if ULIDs are used in the 'Model' class. Expanded 'ModelGenerator' class to act accordingly if ULIDs are used. Added respective test case and fixture files to ensure correct functionality.
Feature/add ulid column type
…/blueprint into feature/add-ulid-column-type
Feature/add ulid column type
This commit expands the migration generation function to support ULID and UUID primary keys, specifically in the context of pivot tables. Tests have been created for this new functionality, and related migration stubs have been updated. This allows the creation of pivot tables with ULID and UUID references, catering to a broader range of database design choices.
The foreign key generation code in migration files has been refactored into a separate method. This update simplifies the main function by extracting complex logic and improves readability of the code. Additionally, the method now supports generation of primary keys with 'ulid' and 'uuid' data types for pivot tables.
Feature/add ulid column type
|
Sorry, this commit is way too large with too many commits and changes for me to consider. If you want a new feature added, I recommend separating your PR into multiple. First making the feature, then additional for refactors. |
|
Thanks for your feedback. This feature involved adding |
| $this->assertEquals([ | ||
| 'models' => [ | ||
| 'Person' => [ | ||
| 'id' => 'ulid primary', |
There was a problem hiding this comment.
It should not be required to say ulid primary, just ulid is fine as it is the conventional id field.
There was a problem hiding this comment.
It isn't required to specify ulid primary. Here is the draft file that was used in that test tests/fixtures/drafts/ulid-shorthand.yaml
There was a problem hiding this comment.
Since it is not needed, please remove ulid primary from all of your new fixtures to avoid confusion for those reviewing them as examples.
There was a problem hiding this comment.
Not sure why the linter is failing in the pipeline. It passes lint checks when I run it locally.
|
Please resolve any open conversation and I'll give this a final review. |
…e generic isIdColumnType
…es to the shorthand `ulid`
|
Looks like there's still a bit of lint. Run |
… optional parameters.
Yes that worked. Thanks. |
List of changes:
ModelandModelGeneratorclassesModelclass.customer_idandtran_idadded.ulidMorphsadded to the test fixtures in all-column-types for drafts, models, and factories.MigrationGeneratorTest.phpfile.ulidtype toModelLexer.php.Blueprint.phpto matchulidanduuid.