Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for ULID column type #657
Add Support for ULID column type #657
Changes from all commits
d896b03
73c8090
9ad1d23
70ae6af
8d307d8
2251bd6
2c2e4f5
cae0567
1e136c4
3eeee20
c71357c
ba8aef3
5ac1b7e
fd7e009
6b4d86d
dece6d9
381bff8
bf058c9
bb24726
0ff644a
14887d7
5e827d3
690bcf7
d63b441
d892679
1170a34
2226e6a
f8c8c91
0f57f5b
ec435d5
47d05c6
461f4e1
2c71e68
f6ff73e
6036e37
a2f9119
3e8a73b
e9b35ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not be required to say
ulid primary
, justulid
is fine as it is the conventionalid
field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't required to specify
ulid primary
. Here is the draft file that was used in that testtests/fixtures/drafts/ulid-shorthand.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is not needed, please remove
ulid primary
from all of your new fixtures to avoid confusion for those reviewing them as examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the linter is failing in the pipeline. It passes lint checks when I run it locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.