Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow exception so that job status is handled #68

Conversation

georgebohnisch
Copy link

Closes #60

@m2jobe
Copy link

m2jobe commented Jan 24, 2020

Tested and looks good

@klimov-paul
Copy link

Such change may break existing applications.
For example: Twilio client throws an exception in case of invalid receiver phone number or in case receiver phone number belongs to unsupported region.
See:

If this PR accepted Laravel application may easily end up in 500 error in case user entered incorrect phone number by a mistake.

@klimov-paul
Copy link

Enhanced solution provided via #73

@atymic
Copy link
Member

atymic commented Apr 8, 2020

Thanks for the PR, introduced in #90 :)

@atymic atymic closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants