Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v3 #90

Merged
merged 7 commits into from
Apr 19, 2020
Merged

feat: v3 #90

merged 7 commits into from
Apr 19, 2020

Conversation

atymic
Copy link
Member

@atymic atymic commented Apr 8, 2020 •
edited
Loading

  • throw exceptions (with ability to ignore specific codes)
  • deferrable provider
  • dedicated config file
  • strict types
  • fix bad tests

TODO:

Closes #70
Closes #72
Closes #60

This was referenced Apr 8, 2020
Closed
Closed
Closed
@gregoriohc gregoriohc mentioned this pull request Apr 8, 2020
Closed
@gregoriohc
Copy link
Member

Would it be interesting to update the Twilio sdk version to 6 as mentioned on PR #89 ?

@gregoriohc gregoriohc mentioned this pull request Apr 8, 2020
Closed
@atymic
Copy link
Member Author

atymic commented Apr 8, 2020

Would it be interesting to update the Twilio sdk version to 6 as mentioned on PR #89 ?

Yep, plan to do that. Will add to the todo.

@gregoriohc
Copy link
Member

Also, it would be interesting to implemente the "universal To" as mentioned in PR #86

@gregoriohc gregoriohc mentioned this pull request Apr 8, 2020
Closed
@atymic atymic force-pushed the v3 branch 4 times, most recently from 9c4962b to 356ac87 Compare April 8, 2020 10:48
atymic added 2 commits April 8, 2020 20:54
@atymic
feat: v3
5da6878 
- throw exceptions (with ability to ignore specific codes)
- deferrable provider
- dedicated config file
- strict types
- fix bad tests
@atymic
feat: bump sdk verson to v6, add github actions CI
d7a6a9d
This was referenced Apr 8, 2020
Closed
Closed
@atymic atymic marked this pull request as ready for review April 12, 2020 02:19
@atymic atymic requested a review from gregoriohc April 12, 2020 02:20
@atymic
Copy link
Member Author

atymic commented Apr 15, 2020

@gregoriohc if you'd like to review please go ahead, otherwise i'll merge in a couple of days :)

klimov-paul
klimov-paul reviewed Apr 16, 2020
View reviewed changes
src/TwilioProvider.php Outdated Show resolved Hide resolved
klimov-paul
klimov-paul reviewed Apr 16, 2020
View reviewed changes
src/TwilioProvider.php Outdated Show resolved Hide resolved
@atymic atymic merged commit d0189ba into laravel-notification-channels:master Apr 19, 2020
@atymic atymic deleted the v3 branch April 19, 2020 21:42
This was referenced Apr 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klimov-paul klimov-paul klimov-paul left review comments

@gregoriohc gregoriohc gregoriohc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atymic @gregoriohc @klimov-paul