Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check length of host group before erroring. Fix race condition #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check length of host group before erroring. Fix race condition #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/host.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
# And now fetch the newly made group to be sure it worked
# and for later use
groups = connection.query(get_groups_request)
Chef::Log.error('Error creating groups, see Chef errors') if result.nil?
Chef::Log.error('Error creating groups, see Chef errors') if result.nil? || groups.length == 0
elsif groups.length == 1
Chef::Log.info "Group #{current_group} already exists"
else
Expand Down