Check length of host group before erroring. Fix race condition #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple hosts run at the same time with a new host group, a race condition occurs. All the hosts query and find that the host group does not exist. They then all try to create the host group. Only one will succeed, the others will get an api error. If the group gets created/exists, the subuquent call to get the host group will have one result.
|
Fixes #215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple hosts run at the same time with a new host group,
a race condition occurs. All the hosts query and find that the
host group does not exist. They then all try to create the host
group. Only one will succeed, the others will get an api error.
If the group gets created/exists, the subuquent call to get the host
group will have one result.