Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs edits #65

Merged
merged 6 commits into from
Oct 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ Important Classes
.. toctree::
:maxdepth: 1

op_linop
operator
functional
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def patched_parse(self):

# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
exclude_patterns = ["tmp", "*.tmp.*", "*.tmp"]
exclude_patterns = ["tmp", "*.tmp.*", "*.tmp", "index.ipynb"]

# If true, '()' will be appended to :func: etc. cross-reference text.
add_function_parentheses = False
Expand Down
2 changes: 1 addition & 1 deletion docs/source/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ SCICO Documentation
overview
team
install
important_classes
classes
notes
examples
API Reference <_autosummary/scico.rst>
Expand Down
3 changes: 0 additions & 3 deletions docs/source/op_linop.rst → docs/source/operator.rst
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
Operators
=========

.. todo::
* Document :func:`._wrap_mul_div_scalar`, :func:`._wrap_sum`

An operator is a map from :math:`\mathbb{R}^n` or :math:`\mathbb{C}^n`
to :math:`\mathbb{R}^m` or :math:`\mathbb{C}^m`.
In SCICO, operators are primarily used to represent imaging systems
Expand Down
6 changes: 3 additions & 3 deletions docs/source/overview.rst
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@ SCICO is designed to solve problems of the form

.. math::

\argmin_{\mb{x}} \; f(\mb{x}) + \sum_{r=1}^R g_r(C_r (\mb{x})),
\argmin_{\mb{x}} \; f(\mb{x}) + \sum_{k=1}^K g_k(C_k (\mb{x})),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change here a general preference for k or trying to avoid overloading r or R?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seemed that r is not a great choice for the indexing variable since it deviates from the standard use of i,j,k,m,n. I don't have very strong feelings about this, though, if anyone objects.


with :math:`\mb{x} \in \mathbb{R}^{n}` representing the reconstruction,
e.g., a 1D, 2D, 3D, or 3D+time image,
:math:`C_r: \mathbb{R}^{n} \to \mathbb{R}^{m_r}`
:math:`C_k: \mathbb{R}^{n} \to \mathbb{R}^{m_k}`
being regularization operators,
and :math:`f: \mathbb{R}^{n} \to \mathbb{R}`
and :math:`g_r: \mathbb{R}^{m_r} \to \mathbb{R}`
and :math:`g_k: \mathbb{R}^{m_k} \to \mathbb{R}`
being functionals associated with the data fidelity
and regularization, respectively.

Expand Down
4 changes: 0 additions & 4 deletions docs/source/style.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ We aim to incorporate `PEP 526 <https://www.python.org/dev/peps/pep-0484/>`_ typ

Our coding conventions are based on both the `numpy conventions <https://numpydoc.readthedocs.io/en/latest/format.html#overview>`_ and the `google docstring conventions <https://google.github.io/styleguide/pyguide.html>`_.

.. todo::

Briefly explain which components are taken from each convention (see above) to avoid ambiguity in cases in which they differ.

Unicode variable names are allowed for internal usage (e.g. for Greek characters for mathematical symbols), but not as part of the public interface for functions or methods.


Expand Down