Minor docs edits #65
Merged
Minor docs edits #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,14 +68,14 @@ SCICO is designed to solve problems of the form | |||
|
|
|||
| .. math:: | |||
|
|
|||
| \argmin_{\mb{x}} \; f(\mb{x}) + \sum_{r=1}^R g_r(C_r (\mb{x})), | |||
| \argmin_{\mb{x}} \; f(\mb{x}) + \sum_{k=1}^K g_k(C_k (\mb{x})), | |||
There was a problem hiding this comment.
Is the change here a general preference for k or trying to avoid overloading r or R?
There was a problem hiding this comment.
It just seemed that r is not a great choice for the indexing variable since it deviates from the standard use of i,j,k,m,n. I don't have very strong feelings about this, though, if anyone objects.
|
I assumed it was r for regularizer but no objections to changing it.
…On Tue, Oct 26, 2021, 15:07 Brendt Wohlberg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/source/overview.rst
<#65 (comment)>:
> @@ -68,14 +68,14 @@ SCICO is designed to solve problems of the form
.. math::
- \argmin_{\mb{x}} \; f(\mb{x}) + \sum_{r=1}^R g_r(C_r (\mb{x})),
+ \argmin_{\mb{x}} \; f(\mb{x}) + \sum_{k=1}^K g_k(C_k (\mb{x})),
It just seemed that r is not a great choice for the indexing variable
since it deviates from the standard use of i,j,k,m,n. I don't have very
strong feelings about this, though, if anyone objects.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#65 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANUBO7C4ZXZHM3R6Q7D3YHDUI4KBNANCNFSM5GWO4ODQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor docs edits.