Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC: Fix link issue related to CSK for Debug builds. #767

Merged
merged 1 commit into from
Mar 17, 2020

Commits on Mar 13, 2020

  1. MSVC: Fix link issue related to CSK for Debug builds.

    Background:
    
    + Nightly regressions that target Visual Studio 2019 show `compton_tCompton_1`
      failing. I discovered that this test failure was cased by linking to one
      compton.dll file by when the test was executed a different dynamic library
      was called.
    
    Changes:
    
    + I modified the logic in `copy_dll_link_libraries_to_build_dir`
      (`component_macros.cmake`) to copy the correct flavor (Debug vs. Release) to
      the test installation.  This change required a small chagne to
      `FindEOSPAC.cmake` to keep it working.
    + Also fix a minor typo in `generate_dll_declspec.cmake` that could prevent
      `DLL_PUBLIC` function decoration from working properly.
    + Minor updates were added to the build system's debug helper
      `print_target_properties.cmake`.
    KineticTheory committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    1275dfa View commit details
    Browse the repository at this point in the history