Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC: Fix link issue related to CSK for Debug builds. #767

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Mar 13, 2020

Background

  • Nightly regressions that target Visual Studio 2019 show compton_tCompton_1 failing. I discovered that this test failure was cased by linking to one compton.dll file by when the test was executed a different dynamic library was called.

Description of changes

  • I modified the logic in copy_dll_link_libraries_to_build_dir (component_macros.cmake) to copy the correct flavor (Debug vs. Release) to the test installation. This change required a small chagne to FindEOSPAC.cmake to keep it working.
  • Also fix a minor typo in generate_dll_declspec.cmake that could prevent DLL_PUBLIC function decoration from working properly.
  • Minor updates were added to the build system's debug helper print_target_properties.cmake.

Status

Background:

+ Nightly regressions that target Visual Studio 2019 show `compton_tCompton_1`
  failing. I discovered that this test failure was cased by linking to one
  compton.dll file by when the test was executed a different dynamic library
  was called.

Changes:

+ I modified the logic in `copy_dll_link_libraries_to_build_dir`
  (`component_macros.cmake`) to copy the correct flavor (Debug vs. Release) to
  the test installation.  This change required a small chagne to
  `FindEOSPAC.cmake` to keep it working.
+ Also fix a minor typo in `generate_dll_declspec.cmake` that could prevent
  `DLL_PUBLIC` function decoration from working properly.
+ Minor updates were added to the build system's debug helper
  `print_target_properties.cmake`.
@KineticTheory KineticTheory added this to the Draco-7_6_0 milestone Mar 13, 2020
@KineticTheory KineticTheory self-assigned this Mar 13, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #767 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #767   +/-   ##
=======================================
  Coverage       94%     94%           
=======================================
  Files          367     367           
  Lines        17237   17237           
=======================================
  Hits         16204   16204           
  Misses        1033    1033

@KineticTheory KineticTheory changed the title WIP: MSVC: Fix link issue related to CSK for Debug builds. MSVC: Fix link issue related to CSK for Debug builds. Mar 15, 2020
@KineticTheory
Copy link
Collaborator Author

This is a build system only PR that only impacts the Visual Studio build. Since we are short on reviewers, I'm merging w/o a 2nd reviewer. Feedback is welcome wrt to breaking our normal rules.

@KineticTheory KineticTheory merged commit 40c1a7e into lanl:develop Mar 17, 2020
@KineticTheory KineticTheory deleted the msvc_fix_csk_linking branch March 17, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant