-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draco-7_2_0 #637
Merged
Merged
Draco-7_2_0 #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Provided updated ChangeLog notes, information in `Release.cc`, updated version numbers in `CMakeLists.txt`. + The logic used to set the "patch" digit (third digit) of the version wasn't working correctly and needed to be fixed. Normally, the "patch" value is the configure date. The release scripts use special logic to force this value to a specific integral value (usually "0"). + Update the `*-env.sh` scripts to supported requested toolchains for this release: - gcc/7.4.0 instead of gcc/6.4.0 - intel/18.0.2 - attempted intel/17.0.4 but the release failed due to a compiler bug. - For ATS-1, force unload the hugepages module.
RyanWollaeger
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# ATS-2 Environment setups | ||
#------------------------------------------------------------------------------# | ||
|
||
case $ddir in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that function definitions could be embedded in case statements - that's pretty neat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Status