Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draco-7_2_0 #637

Merged
merged 5 commits into from
Jun 19, 2019
Merged

Draco-7_2_0 #637

merged 5 commits into from
Jun 19, 2019

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Jun 17, 2019

Description of changes

Status

+ Provided updated ChangeLog notes, information in `Release.cc`, updated version
  numbers in `CMakeLists.txt`.
+ The logic used to set the "patch" digit (third digit) of the version wasn't
  working correctly and needed to be fixed.  Normally, the "patch" value is the
  configure date.  The release scripts use special logic to force this value to
  a specific integral value (usually "0").
+ Update the `*-env.sh` scripts to supported requested toolchains for this
  release:
  - gcc/7.4.0 instead of gcc/6.4.0
  - intel/18.0.2
  - attempted intel/17.0.4 but the release failed due to a compiler bug.
  - For ATS-1, force unload the hugepages module.
@KineticTheory KineticTheory mentioned this pull request Jun 17, 2019
7 tasks
@KineticTheory KineticTheory changed the title WIP: Draco-7_2_0 Draco-7_2_0 Jun 19, 2019
@KineticTheory KineticTheory self-assigned this Jun 19, 2019
@KineticTheory KineticTheory added this to the Draco-7_2_0 milestone Jun 19, 2019
Copy link
Contributor

@RyanWollaeger RyanWollaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# ATS-2 Environment setups
#------------------------------------------------------------------------------#

case $ddir in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that function definitions could be embedded in case statements - that's pretty neat.

@RyanWollaeger RyanWollaeger merged commit b52cd59 into develop Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants