Add function to query environment vars; class to represent SLURM info… #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KineticTheory
requested changes
Jun 10, 2019
timmah
force-pushed
the
feat-add-slurm-vars
branch
from
c3e1f0a
to
d581aee
Compare
|
@timmah You can ignore appveyor failure on this PR. I updated the compiler version and there are new warnings that are unrelated to your changes. |
timmah
force-pushed
the
feat-add-slurm-vars
branch
2 times, most recently
from
73518fb
to
59dca45
Compare
…rmation. Improve how get_env_val communicates whether a key is defined in the environment. Include <tuple>. Correct warnable syntactic shortcoming. Fix directory mismatch in doxygen comments. Fix doxygen usage. Another doxygen fix. Another clang-format.
timmah
force-pushed
the
feat-add-slurm-vars
branch
from
59dca45
to
1683e3a
Compare
KineticTheory
approved these changes
Jun 11, 2019
| template <typename T> | ||
| std::pair<bool, T> get_env_val(std::string const &key, T default_value = T{}) { | ||
| static_assert(std::is_default_constructible<T>::value, | ||
| "get_env_val only usable with default constructible types"); |
KineticTheory
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rmation.
Background
Purpose of Pull Request
get_env_val, that calls the C getenv function and converts the result, if any, to the specified type.get_env_val()returns whether the key is defined in the environment, and the value found, if any. The SLURM_Task_Info class uses get_env_val to locate some SLURM-specific quantities.Description of changes
Status