-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable Name Conventions #26
Comments
Another challenge is how to deal with variable products. It has been convenient to use w for the product of two voltages (i.e. v). But we need a more general rule for the product of other complex numbers. I suggest if x and y are complex numbers then xy can be represented as,
Due to the convenient existence of w, which looks like vv, we can use it as a shorthand of these cases,
|
In light of this convention, and that S is the standard value for complex power, should p and q be renamed sr and si? |
We can do the following: at instances where there is no standard agreed upon naming convention like p and q for sr and si, we can follow your proposed scheme. |
I don't think we can rename p and q as sr and si. To many people "know" what p and q mean, and to replace that may cause too much confusion. I tend to agree with Kaarthik here, where we use sr and si whenever there is not an agreed upon notation. |
If we adopt @kaarthiksundar's suggestion, what is the list of standard agreed upon names? Another option is for some parameters like p and q to have two aliases for the same set of variables, the typical name and the standardized convention. It's unclear to me if JuMP could handle that. |
@ccoffrin I am pretty (95%) sure JuMP cannot handle that. I have been experimenting with variable names for quite some time and in my experience, that is not possible. I guess the only agreed upon names are p, q and w. |
It could handle it with some hacks, but would need to be convinced that it's worth making the scoping more complicated and confusing than it already is. You could just use your own dictionary. |
I think if we carefully document that p and q are the exception to the convention (and why), this will be ok. w is a somewhat newer convention, so maybe that can be changed without too much heart burn? |
I like the w notation and It's very nice in the SDP models. I think we have a plan.
we can revisit multiple aliases at a later time, if this becomes supported in JuMP. |
works for me |
* rename variable_phase_angle to variable_voltage_angle * renaming constraint_phase_angle_difference to constraint_voltage_angle_difference * rename variable_phase_angle_difference to variable_voltage_angle_difference * rename check_phase_angle_differences to check_voltage_angle_differences * rename variables v to vm and t to va * adding notes to changelog [ci skip] * fixing polar voltage base names * rename v_from and w_from to v_fr and w_fr closes #126, addressed #26.
A proposal for dual value naming conventions,
Some common examples,
|
I'd like to make a proposal as well. Classically, power system people define impedance as z = r + j x and admittance as y = g + j b. At the moment, the parameter symbols defining impedance of a pi-section in PowerModels are like that for the series element. However, |
@frederikgeth, you make a good point. I think |
Review the use of underscores in |
I propose the following a standard naming convention for the polar and rectangular variable spaces, let "v" be a complex number, then:
The text was updated successfully, but these errors were encountered: