Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Model Renaming #423

Open
ccoffrin opened this issue Dec 1, 2018 · 7 comments
Open

Data Model Renaming #423

ccoffrin opened this issue Dec 1, 2018 · 7 comments

Comments

@ccoffrin
Copy link
Member

ccoffrin commented Dec 1, 2018

Revisit the names for everything in the data model and update to consistent and clean naming conventions.

@frederikgeth, this is not coming anytime soon, but we can bike shed about it in this thread.

@ccoffrin ccoffrin added this to the PowerModels v1.0 milestone Dec 1, 2018
@jd-lara
Copy link
Contributor

jd-lara commented Dec 1, 2018

I would be interested in reaching some convergence between what I want to achieve in PowerSystems and PowerModels' data structure and naming.

@ccoffrin
Copy link
Member Author

ccoffrin commented Dec 1, 2018

By all means. All proposals are welcome in this thread.

@frederikgeth
Copy link
Collaborator

We may want to start with including energy, and time symbols here, define suffixes for all entities (e.g.g for generators), map these names to the parameters and variables and define the default associated SI units?

To which degree should we attempt to future-proof the data model (e.g. angle range of phase-shifting transformers or tap range of OLTC transformers)?

@ccoffrin
Copy link
Member Author

ccoffrin commented Dec 4, 2018

My goal would be to come up with something like a style guide for parameter names, similar to what we did for variables in #26, then update the data model to be consistent with those conventions.

I would not be overly concerned with future-proofing. I think just covering the all the parameters we have will provide fairly robust guidelines.

@jd-lara
Copy link
Contributor

jd-lara commented Dec 4, 2018

Making the convention consistent with PowerSystems/Simulations would be a great goal @claytonpbarrows

@ccoffrin ccoffrin modified the milestones: v1.0.0, Parameter Renaming Apr 25, 2019
@ccoffrin
Copy link
Member Author

ccoffrin commented Aug 9, 2019

@frederikgeth when we do this renaming, should we rename thermal_rating to power_rating? Seems core consistent with current_rating

@frederikgeth
Copy link
Collaborator

In favor of being explicit in terms of power and current for ratings instead of 'thermal'. (A thermal limit eventually should be the maximum acceptable conductor temperature.)

@ccoffrin ccoffrin modified the milestones: Parameter Renaming, v0.16.0 Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants