feat(model): add validation for custom disclaimer length #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed `custom_disclaimer` to `_custom_disclaimer` for encapsulation. - Introduced a property and setter to control access to `_custom_disclaimer`. - Added validation in the setter to ensure the custom disclaimer does not exceed 512 characters, enhancing data integrity.
dosubot
bot
added
size:S
5 tasks
crazywoola
approved these changes
Nov 5, 2024
crazywoola
deleted the
feat/add-validation-for-custom-disclaimer-length
branch
BenjaminX
pushed a commit
to BenjaminX/ben-dify
that referenced
this pull request
Nov 5, 2024
Yeuoly
pushed a commit
that referenced
this pull request
Nov 5, 2024
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Nov 5, 2024
* commit '7f583ec1ac6e7fb5269ed696f40a96a8b6b6f5fc': (176 commits) chore: update version to 0.11.0 across all relevant files (langgenius#10278) fix: iteration none output error (langgenius#10295) fix(http_request): improve parameter initialization and reorganize tests (langgenius#10297) fix typo: writeOpner to writeOpener (langgenius#10290) fix: handle KeyError when accessing rules in CleanProcessor.clean (langgenius#10258) fix: borken faq url in CONTRIBUTING.md (langgenius#10275) feat: add xAI model provider (langgenius#10272) feat(model_runtime): add new model 'claude-3-5-haiku-20241022' (langgenius#10285) fix(model_runtime): fix wrong max_tokens for Claude 3.5 Haiku on Amazon Bedrock (langgenius#10286) feat(model): add validation for custom disclaimer length (langgenius#10287) fix(node): correct file property name in function switch (langgenius#10284) refactor the logic of refreshing access_token (langgenius#10068) chore: translate i18n files (langgenius#10273) Updates: Add mplfonts library for customizing matplotlib fonts and Va… (langgenius#9903) feat: Iteration node support parallel mode (langgenius#9493) fix(workflow): handle else condition branch addition error in if-else node (langgenius#10257) feat(document_extractor): support tool file in document extractor (langgenius#10217) feat: support Claude 3.5 Haiku on Amazon Bedrock (langgenius#10265) refactor(parameter_extractor): implement custom error classes (langgenius#10260) fix: buitin tool aippt (langgenius#10234) ... # Conflicts: # .github/workflows/build-push.yml # api/Dockerfile # api/core/workflow/nodes/code/code_node.py
iamjoel
pushed a commit
that referenced
this pull request
Nov 7, 2024
AlwaysBluer
pushed a commit
to AlwaysBluer/dify
that referenced
this pull request
Nov 14, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
custom_disclaimerto_custom_disclaimerfor encapsulation._custom_disclaimer.Fixes #9772
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration