Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document_extractor): support tool file in document extractor #10217

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

Description

  • Remove redundant check for local file transfer method.
  • Simplify logic by directly using file_manager.download for unsupported methods.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Remove redundant check for local file transfer method.
- Simplify logic by directly using `file_manager.download` for unsupported methods.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request labels Nov 3, 2024
@laipz8200 laipz8200 changed the title feat(document_extractor): streamline file download logic feat(document_extractor): support tool file in document extractor Nov 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@crazywoola crazywoola merged commit 2c4d8db into main Nov 5, 2024
9 checks passed
@crazywoola crazywoola deleted the feat/streamline-file-download-logic branch November 5, 2024 01:49
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Nov 5, 2024
* commit '7f583ec1ac6e7fb5269ed696f40a96a8b6b6f5fc': (176 commits)
  chore: update version to 0.11.0 across all relevant files (langgenius#10278)
  fix: iteration none output error (langgenius#10295)
  fix(http_request): improve parameter initialization and reorganize tests (langgenius#10297)
  fix typo: writeOpner to writeOpener (langgenius#10290)
  fix: handle KeyError when accessing rules in CleanProcessor.clean (langgenius#10258)
  fix: borken faq url in CONTRIBUTING.md (langgenius#10275)
  feat: add xAI model provider (langgenius#10272)
  feat(model_runtime): add new model 'claude-3-5-haiku-20241022' (langgenius#10285)
  fix(model_runtime): fix wrong max_tokens for Claude 3.5 Haiku on Amazon Bedrock (langgenius#10286)
  feat(model): add validation for custom disclaimer length (langgenius#10287)
  fix(node): correct file property name in function switch (langgenius#10284)
  refactor the logic of refreshing access_token (langgenius#10068)
  chore: translate i18n files (langgenius#10273)
  Updates: Add mplfonts library for customizing matplotlib fonts and Va… (langgenius#9903)
  feat: Iteration node support parallel mode (langgenius#9493)
  fix(workflow):  handle else condition branch addition error in if-else node (langgenius#10257)
  feat(document_extractor): support tool file in document extractor (langgenius#10217)
  feat: support Claude 3.5 Haiku on Amazon Bedrock (langgenius#10265)
  refactor(parameter_extractor): implement custom error classes (langgenius#10260)
  fix: buitin tool aippt (langgenius#10234)
  ...

# Conflicts:
#	.github/workflows/build-push.yml
#	api/Dockerfile
#	api/core/workflow/nodes/code/code_node.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants