Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix location of landchain-core dependency #2

Merged
merged 3 commits into from
Mar 8, 2024
Merged

fix location of landchain-core dependency #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1c0623
fix location of landchain-core dependency
mattf Mar 8, 2024
51faf69
no extended-test directories present
mattf Mar 8, 2024
bc3a3bd
repository not setup to lint "."
mattf Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/scripts/check_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
)
):
# add all LANGCHAIN_DIRS for infra changes
dirs_to_run["extended-test"].update(NVIDIA_DIRS)
dirs_to_run["lint"].add(".")
# dirs_to_run["lint"].add(".")
mattf marked this conversation as resolved.
Show resolved Hide resolved
pass

if any(file.startswith(dir_) for dir_ in NVIDIA_DIRS):
for dir_ in NVIDIA_DIRS:
Expand All @@ -45,14 +45,14 @@
f"Unknown lib: {file}. check_diff.py likely needs "
"an update for this new library!"
)
elif any(file.startswith(p) for p in ["docs/", "templates/", "cookbook/"]):
dirs_to_run["lint"].add(".")
# elif any(file.startswith(p) for p in ["docs/", "templates/", "cookbook/"]):
# dirs_to_run["lint"].add(".")

outputs = {
"dirs-to-lint": list(
dirs_to_run["lint"] | dirs_to_run["test"] | dirs_to_run["extended-test"]
dirs_to_run["lint"] | dirs_to_run["test"]
),
"dirs-to-test": list(dirs_to_run["test"] | dirs_to_run["extended-test"]),
"dirs-to-test": list(dirs_to_run["test"]),
}
for key, value in outputs.items():
json_output = json.dumps(value)
Expand Down
Loading
Loading