Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix location of landchain-core dependency #2

Merged
merged 3 commits into from
Mar 8, 2024
Merged

fix location of landchain-core dependency #2

merged 3 commits into from
Mar 8, 2024

Conversation

mattf
Copy link
Collaborator

@mattf mattf commented Mar 8, 2024

this is necessary now that the code is outside the langchain repository

@mattf mattf self-assigned this Mar 8, 2024
@mattf mattf requested a review from VKudlay March 8, 2024 16:05
@VKudlay VKudlay self-assigned this Mar 8, 2024
VKudlay
VKudlay approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@VKudlay VKudlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the time being. If the diff script mod is undesirable, it will come out in the wash when we chat about uploading documentation.

.github/scripts/check_diff.py Show resolved Hide resolved
@mattf mattf merged commit 3f4f977 into main Mar 8, 2024
12 checks passed
@mattf mattf deleted the mattf/fix-langchain-core-dep branch March 8, 2024 17:56
mattf pushed a commit that referenced this pull request Mar 30, 2024
@VKudlay
Merge pull request #2 from langchain-ai/mattf/patch-1
967e675 
fix indent level, always yield
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VKudlay VKudlay VKudlay approved these changes

Assignees

@mattf mattf

@VKudlay VKudlay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattf @VKudlay