Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing api_key = None issue and try_raise parsing miss #13

Merged
merged 6 commits into from
Mar 30, 2024
Merged

Fix missing api_key = None issue and try_raise parsing miss #13

merged 6 commits into from
Mar 30, 2024

Conversation

VKudlay
Copy link
Collaborator

@VKudlay VKudlay commented Mar 29, 2024

When a user tries to initialize a model without having an API key pulled in from the environment of constructor, it fails because the API key will be none. The one-line fix on top addresses this.

An invalid key will cause an error from the server, and current code in try_raise will miss it due to a change in error message structure. A minimal modification is implemented to quickly remedy this. Further testing necessary later to see what all we might encounter in the error message space.

@VKudlay VKudlay requested a review from mattf March 29, 2024 06:24
Copy link
Collaborator

@mattf mattf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i'll follow up with lint and test fixes.

fixes #5

@VKudlay VKudlay marked this pull request as ready for review March 29, 2024 12:28
@mattf mattf merged commit 6210013 into langchain-ai:main Mar 30, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants