-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to langchain-core 0.3 (langchain_core.pydantic_v1 removal) #101
Merged
Merged
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
364dc96
start v0.3 migration
baskaryan 9df872f
move api key var name out of class, it is a constant
mattf efe24f3
move base url var name out of class, it is a constant; address ModelP…
mattf 3e5b4fe
make base_url Optional
mattf f3a44b1
get value from ModelPrivateAttr with .default
mattf d57b1aa
set last_inputs default
mattf e2aaee7
move default base url out of class, it is a constant; address ModelPr…
mattf 7781580
move default model name out of class, it is a constant
mattf f074863
ensure optional model has a default
mattf 72a44ef
ensure optional truncate has default
mattf f1b8e1f
move default model name out of class, it is a constant
mattf d000152
move default batch size out of class, it is a constant
mattf 2e8bbd0
update test to use model_config instead of Config
mattf e963a8d
schema is deprecated -> model_json_schema
mattf 3755143
remove structured output test for langchain_core.pydantic_v1
mattf 9044a6a
remove langchain_core.pydantic_v1 from docs
mattf 8323298
Merge branch 'main' into bagatur/start_v0.3
mattf af26c31
fix cls._api_key_var -> _API_KEY_VAR after main merge
mattf d59d153
align ChatNVIDIA.with_structured_output with BaseChatModel.with_struc…
mattf 29a748f
align ChatNVIDIA.bind_tools with BaseChatModel.bind_tools' signature
mattf e8078c1
Merge branch 'dev-v0.3' into bagatur/start_v0.3
mattf a04d69e
Merge branch 'dev-v0.3' into bagatur/start_v0.3
mattf f107146
fix type error in test mock, uncovered thanks to pydantic v2
mattf cd387b3
update copy (deprecated) -> model_copy
mattf e35da45
add @tool test with Annotated
mattf 8d2bc6b
convert @validator(always=True) to @model_validator(mode="after")
mattf 5bc0080
fix input error in test mock, uncovered thanks to pydantic v2
mattf 9ff8d5d
schema -> model_json_schema to address deprecation of schema
mattf 24c3859
ignore warning about mock-model
mattf 00eb8a0
ignore warning about model not supporting structured output, model is…
mattf fbc669e
model_name -> mdl_name to avoid the protected namespace "model_"
mattf 83b1c91
use github version of langchain-core for dev & test
mattf 1015888
update poetry.lock
mattf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also add
protected_namespaces=()
to remove warnings if we want to keep existing field namesWe did this on all instances of RunnableSerializable in langchain-core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i considered that and figured this since is internal code (not user visible), it was fine to leave the namespace protection in place.
unfortunately, i didn't see a way to exclude a specific field, which would be the best solution imho.