migrate to langchain-core 0.3 (langchain_core.pydantic_v1 removal) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rivateAttr errors
mattf
changed the title
…tured_output's signature
|
@baskaryan ptal |
ccurme
approved these changes
Sep 18, 2024
Comment on lines
+55
to
+57
| model_config = ConfigDict( | ||
| arbitrary_types_allowed=True, | ||
| ) |
There was a problem hiding this comment.
We can also add protected_namespaces=() to remove warnings if we want to keep existing field names
Suggested change
| model_config = ConfigDict( | |
| arbitrary_types_allowed=True, | |
| ) | |
| model_config = ConfigDict( | |
| arbitrary_types_allowed=True, | |
| protected_namespaces=(), | |
| ) |
We did this on all instances of RunnableSerializable in langchain-core.
There was a problem hiding this comment.
i considered that and figured this since is internal code (not user visible), it was fine to leave the namespace protection in place.
unfortunately, i didn't see a way to exclude a specific field, which would be the best solution imho.
| @@ -26,7 +26,7 @@ pytest-mock = "^3.10.0" | |||
| syrupy = "^4.0.2" | |||
| pytest-watcher = "^0.3.4" | |||
| pytest-asyncio = "^0.21.1" | |||
| langchain-core = { git = "https://github.com/langchain-ai/langchain.git", subdirectory = "libs/core", tag = "langchain-core==0.2.40" } | |||
There was a problem hiding this comment.
wondering if we still want to install from source for test dependencies (e.g., remove specification of tag)
There was a problem hiding this comment.
i agree, i'll make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.