Ensure all .cpp files have using namespace codal.
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of: lancaster-university/codal-microbit-v2#240 Cannot remove all header files usage of `using namesapce` yet as that will affect other CODAL targets that might not have apply this type of patch yet.
microbit-carlos
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
This is a safe first step towards #43, so I can merge this now to include in the next codal-microbit-v2 tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of:
using namespace codalshouldn't be used in header files codal-microbit-v2#240Cannot remove all header files usage of
using namesapceyet, as done in PR #43, as that will affect other CODAL targets that might not have apply this type of patch yet.