-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace using namespace
in headers with explicit namespaces.
#43
Replace using namespace
in headers with explicit namespaces.
#43
Conversation
0e50f9d
to
16dda9b
Compare
Okay, had to leave the I think this approach, keeping some of the namespace in this PR so that is safe to merge, even if it means more PRs in total, is probably a bit easier to manage than orchestrating several PRs to be merged in order. |
16dda9b
to
a490899
Compare
7470f39
to
4a4cdba
Compare
Flag introduced in codal-core in: lancaster-university/codal-core@509086c By default the `using namespace` line would still be present, as removing it can cause some codal targets to break if they depend on the namespace to be set up globally. For example, the codal-microbit-v2 target had this update to fix the namespacing: lancaster-university/codal-microbit-v2#437 This patch is part of: lancaster-university/codal-microbit-v2#240
This PR is one part to resolve issue lancaster-university/codal-microbit-v2#240:
using namespace codal
shouldn't be used in header files codal-microbit-v2#240To avoid namespace pollution headers should not use
using namespace codal;
, and instead it can be added into any.cpp
files that needed (all of them in this repo).I still need to test this PR in isolation with a normal CODAL build, so I'll leave this as a draft PR until I've finished that.