Don't crash when calling gc() on a committed TyperState #13408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An already-committed TyperState might be committed again when errors are flushed (cf scala#12827, scala#13150) and `commit()` calls `gc()`. This operation could crash before this commit because we attempted to instantiate type variables no longer owned by the TyperState. We fix this by clearing `ownedVars` when committing a TyperState (because after committing it no longer owns any type variable). Fixes scala#13407.
odersky
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An already-committed TyperState might be committed into when errors are
flushed (cf #12827, #13150) and
commit()callsgc(). This operationcould crash before this commit because we attempted to instantiate type
variables no longer owned by the TyperState. We fix this by clearing
ownedVarswhen committing a TyperState (because after committing it nolonger owns any type variable).
Fixes #13407.