Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when calling gc() on a committed TyperState #13408

Merged
merged 1 commit into from
Aug 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/core/TyperState.scala
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ class TyperState() {
targetState.mergeConstraintWith(this)
targetState.gc()
isCommitted = true
ownedVars = SimpleIdentitySet.empty
}

/** Ensure that this constraint does not associate different TypeVars for the
Expand Down
19 changes: 19 additions & 0 deletions tests/neg/i13407.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import scala.quoted.Type

trait Tensor[S <: Tuple] {
def sum[Axis <: Shape: Type](axis: Axis): Tensor[S] = { // error
Tensor.mk
}
}

object Tensor {
def mk[S <: Tuple]: Tensor[S] = new Tensor {}
}

object Foo {
val t1: Tensor[("batch", "len", "embed")] = Tensor.mk
def foo(x: Any) = {

}
foo(foo(t1.sum("len"))) // error
}