Avoid crash by relaxing TyperState assertion #13150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
added
the
backport:nominated
odersky
approved these changes
Jul 26, 2021
Flushing a reporter might force error messages (in particular when a StoreReporter is flushed into a non-StoreReporter), and the TyperState of the context captured in an error message might already be committed at this point. In ea6449f I tried to deal with this by flushing before committing but that's not sufficient since the reporter we're flushing might contain error messages from a more deeply nested TyperState. So this commit just relaxes the assertion (ideally we would also check that only TyperStates created in a committed TyperState can be committed in one, but keeping track of that would require an extra field in TyperState).
smarter
force-pushed
the
relax-tstate-assert
branch
from
7366440
to
1380104
Compare
smarter
added
backport:accepted
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Aug 28, 2021
An already-committed TyperState might be committed again when errors are flushed (cf scala#12827, scala#13150) and `commit()` calls `gc()`. This operation could crash before this commit because we attempted to instantiate type variables no longer owned by the TyperState. We fix this by clearing `ownedVars` when committing a TyperState (because after committing it no longer owns any type variable). Fixes scala#13407.
dwijnand
removed
the
backport:accepted
olsdavis
pushed a commit
to olsdavis/dotty
that referenced
this pull request
Apr 4, 2022
An already-committed TyperState might be committed again when errors are flushed (cf scala#12827, scala#13150) and `commit()` calls `gc()`. This operation could crash before this commit because we attempted to instantiate type variables no longer owned by the TyperState. We fix this by clearing `ownedVars` when committing a TyperState (because after committing it no longer owns any type variable). Fixes scala#13407.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushing a reporter might force error messages (in particular when a
StoreReporter is flushed into a non-StoreReporter), and the TyperState
of the context captured in an error message might already be committed
at this point. In ea6449f I tried to
deal with this by flushing before committing but that's not sufficient
since the reporter we're flushing might contain error messages from a
more deeply nested TyperState. So this commit just relaxes the assertion
(ideally we would also check that only TyperStates created in a
committed TyperState can be committed in one, but keeping track of that
would require an extra field in TyperState).
Fixes #13101.
I nominate this PR for backporting since it fixes a regression with respect to 3.0.0