-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Improve lamin load
UX for notebooks & scripts
#1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
🚸 Improve lamin load for notebooks & scripts
🚸 Improve Sep 29, 2024
lamin load
UX for notebooks & scripts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
==========================================
+ Coverage 92.20% 92.41% +0.21%
==========================================
Files 53 54 +1
Lines 6081 6331 +250
==========================================
+ Hits 5607 5851 +244
- Misses 474 480 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid accidental overwrites
Adds a user prompt in case the target file exists to avoid accidental overwrites.
Auto-bumping uid for revising notebooks
Upon revising a notebook a user so far runs into an error that tells them to manually update the
uid
. To avoid this, theuid
is now automatically updated uponlamin load
.Before:
After:
The
uid
is only updated for notebooks, not for other transform types and not for artifacts. Only notebooks are essentially guaranteed to be revised once a user loads them. A script, for instance, is equally likely to be run with the exact same source code hash it had before a user loading it.There is an edge case in which a user might want to re-run the exact same saved notebook with the same
uid
to inspect whether it reproduces the same outputs. This edge case is not yet supported.Avoid conflicts for two user working on the same draft transform
Before:
After:
Slightly more logging for the downloaded local asset
Before:
After:
Fixes integrity issue
Before this PR, it was possible to run
ln.track()
with a bumpeduid
on a notebook with a different filename/key without running into the below error. The error was only raised upon finding an exact match of theuid
. Now it's also raised upon finding a match on the stem uid.Notes
Needs:
lamin load
for notebooks & scripts lamin-cli#83Resolves:
lamin load
#1980draft
transform #1996