Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Two users working on the same draft transform #1996

Closed
falexwolf opened this issue Sep 29, 2024 · 0 comments · Fixed by #1994
Closed

🚸 Two users working on the same draft transform #1996

falexwolf opened this issue Sep 29, 2024 · 0 comments · Fixed by #1994

Comments

@falexwolf
Copy link
Member

falexwolf commented Sep 29, 2024

This is an issue @sunnyosun shared in a verbal discussion yesterday.

It can happen that two users work on the same transform draft at the same time.

Meaning, they both run

ln.track("3qIZOmDUVBwc0001")

in a notebook/script file with the same name.

The first user currently gets:

→ created Transform('3qIZOmDU'), started new Run('asi87URD') at 2024-09-29 10:03:01 UTC

The second user gets:

→ loaded Transform('3qIZOmDU'), started new Run('Q6dM7cRs') at 2024-09-29 10:03:05 UTC

For a script, this behavior is fine. For a notebook, it can lead to conflicting notebook versions for this uid.

Hence, rather than triggering a new run, the second user should have gotten an error and a request to bump the revision.

@falexwolf falexwolf linked a pull request Sep 29, 2024 that will close this issue
@falexwolf falexwolf changed the title 🚸 Two different users working on the same draft transform 🚸 Two users working on the same draft transform Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant