Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with php 8.4 #19

Merged
merged 11 commits into from
Oct 11, 2024
Merged

Updated with php 8.4 #19

merged 11 commits into from
Oct 11, 2024

Conversation

SuperDJ
Copy link
Contributor

@SuperDJ SuperDJ commented Oct 9, 2024

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

  • Added PHP 8.4;
  • Updated squizlabs/php_codesniffer to use the new repository;

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are PHP deprecations getting emitted during tests:

https://github.com/laminas/laminas-xml/actions/runs/11254698819/job/31292696978?pr=19#step:3:380

These will need to be fixed (and PHPUnit should be configured to failOnDeprecation)

There are 4 implicit null arguments by the look of it

@SuperDJ
Copy link
Contributor Author

SuperDJ commented Oct 10, 2024

@gsteel Unfortunately the optional parameter order is deprecated as well https://github.com/laminas/laminas-xml/actions/runs/11274526733/job/31353887275?pr=19#step:3:231

src/Security.php Outdated Show resolved Hide resolved
phpunit.xml.dist Show resolved Hide resolved
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperDJ If you could trim trailing whitespace in the readme and fix the min PHPunit version, we should have green CI

Thanks for sticking with it!

composer.json Outdated Show resolved Hide resolved
@gsteel gsteel self-assigned this Oct 11, 2024
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SuperDJ - Much appreciated :)

@gsteel gsteel added this to the 1.7.0 milestone Oct 11, 2024
@gsteel gsteel merged commit 3a7850d into laminas:1.7.x Oct 11, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants