-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated with php 8.4 #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are PHP deprecations getting emitted during tests:
These will need to be fixed (and PHPUnit should be configured to failOnDeprecation
)
There are 4 implicit null arguments by the look of it
@gsteel Unfortunately the optional parameter order is deprecated as well https://github.com/laminas/laminas-xml/actions/runs/11274526733/job/31353887275?pr=19#step:3:231 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperDJ If you could trim trailing whitespace in the readme and fix the min PHPunit version, we should have green CI
Thanks for sticking with it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SuperDJ - Much appreciated :)
Description
squizlabs/php_codesniffer
to use the new repository;