-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages and PHP version #18
Conversation
@SuperDJ Please check the failing checks: https://github.com/laminas/laminas-xml/actions/runs/11233189933/job/31226396126?pr=18 |
@froschdesign could you elaborate on the further problems? As only php 8.1 appears to fails, could we already consider dropping support for it? I'm aware of the PHP lifecycle not dropping support for 8.1 yet. |
This will not help, because the problem is not the PHP version, but that there are new rules for code styling. phpcs.xml validates
<?xml version="1.0"?>
<ruleset name="Laminas coding standard">
<rule ref="./vendor/laminas/laminas-coding-standard/ruleset.xml"/>
<!-- Paths to check -->
<file>src</file>
<file>test</file>
</ruleset>
Running ./vendor/bin/phpcs -q --report=checkstyle | cs2pr
Error: Start tag expected, '<' not found on line 1, column 1
ERROR: Referenced sniff "./vendor/laminas/laminas-coding-standard/ruleset.xml" does not exist https://github.com/laminas/laminas-xml/actions/runs/11233189933/job/31226396126?pr=18 |
I have another suggestion: Update only the PHP version and undo all other changes. |
@froschdesign I know that is possible. But I think it would be nice to get rid of laminas/laminas-zendframework-bridge |
In your own applications you can already remove the bridge via Composer configuration file: "replace": {
"laminas/laminas-zendframework-bridge": "*"
}, |
see other patches that we've done on that front: we explicitly conflict with the |
Closed in favor of #19 |
Description