Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psalm integration #80

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Psalm integration #80

merged 5 commits into from
Oct 12, 2021

Commits on Oct 12, 2021

  1. Psalm integration 

    Signed-off-by: Shankar Konar <[email protected]>
    @konarshankar07 @weierophinney
    konarshankar07 authored and weierophinney committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    6a05fd7 View commit details
    Browse the repository at this point in the history

  2. Removed redundant psalm config file 

    Signed-off-by: Shankar Konar <[email protected]>
    @konarshankar07 @weierophinney
    konarshankar07 authored and weierophinney committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    e35c743 View commit details
    Browse the repository at this point in the history

  3. Fixed phpunit test 

    Signed-off-by: Shankar Konar <[email protected]>
    @konarshankar07 @weierophinney
    konarshankar07 authored and weierophinney committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    0c0cde6 View commit details
    Browse the repository at this point in the history

  4. qa: perform Psalm auto-corrections and establish baseline 

    This patch runs auto-fixes as suggested by Psalm, and establishes an initial baseline.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
    @weierophinney
    weierophinney committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    6a7f4e8 View commit details
    Browse the repository at this point in the history

  5. qa: revert BC break in signature 

    Psalm autofixes added nullable scalar typehint to an argument, and a return type hint, which each would change the signature.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
    @weierophinney
    weierophinney committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    dab0c61 View commit details
    Browse the repository at this point in the history