Psalm integration

[konarshankar07]

Signed-off-by: Shankar Konar [email protected]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

Psalm integration added

[boesing]

Thanks, @konarshankar07
We have to add the new CI pipeline to this package before we can merge this.
Anyways, thanks for your efforts! This will still count for hacktoberfest due to the hacktoberfest-accepted label 👍🏼

@samsonasik might handle the next steps of this, he might have plans on how to proceed with this component.

[konarshankar07]

Hello @boesing
If you provide the steps to add the new CI pipeline then I can implement that too. I guess you are going to implement the github actions for the CI pipeline
Thanks

[froschdesign]

@boesing
The CI workflow is already there, see at the 2.12.x branch:

This branch is 30 commits ahead, 1 commit behind 3.0.x.

https://github.com/laminas/laminas-view/blob/2.12.x/.github/workflows/continuous-integration.yml

Some cleanup is needed: #71

[froschdesign]

@konarshankar07
Please use the 2.12.x as target branch for this pull request. Thanks!

[Ocramius]

Seems like our own deprecations are at fault with the failure here :|

[boesing]

Seems like our own deprecations are at fault with the failure here :|

actually this is due to the phpunit change regarding deprecationsToExceptions.
The Tests which fail are to ensure the the deprecation will be triggered (just not that well implemented) and these now fail in latest phpunit.

[konarshankar07]

@boesing @Ocramius
Yes, I have fixed this here laminas/laminas-crypt@034976e already and will do the same

[boesing]

Overall, LGTM - just a few adjustments so we can avoid suppressions.

Another thing is, that it seems that we only have less than 20 errors in this projects. Would you mind fixing these so we end up having 100% typed code rather than suppressing these few errors via baseline? That would really be appreciated 🙏🏼