Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 3.11.3 into 3.12.x #138

Merged
merged 15 commits into from
Jun 13, 2022
Merged

Conversation

github-actions[bot]
Copy link

Release Notes for 3.11.3

3.11.x bugfix release (patch)

3.11.3

  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1

Bug

laminas-bot and others added 14 commits April 4, 2022 20:20
Updates the CHANGELOG.md file to add a changelog entry for a new 3.11.1 version.
Evidently, a replace rule automatically marks a package as a conflict, so defining both is redundant and causes Packagist not to list the branch/release.

Additionally, this version removes the dependency on container-interop in the require section, since it provides that dependency itself.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
…ation

Fix issues with Composer package validation
Updates the CHANGELOG.md to set the release date.
Updates the CHANGELOG.md file to add a changelog entry for a new 3.11.2 version.
…ias` to a non-user interface

There is a PHP extension around which provides all (most?) PSR interfaces without the need of installing them via composer. Since we do not support this extension and since that extension does not make sense anyways (more details later), we explicitly adding a `conflict` to the `composer.json` so that there are no surprises for projects which do have the `psr` extension installed.

closes #124

Now to the problem with the extension:

There are multiple PSR standards around. Many of them do have multiple major versions around. The extension has to follow semver to avoid breaks in upstream projects. So as of now (v1.2.0), it only provides the interfaces for the v1 versions of the PSR standards.
There is no way to provide multiple major versions of the same PSR interface from within one version of the extension.
Therefore, at some point, an upstream project is either stuck with the v1 versions of the PSR standards or the extension needs to create a hilarious amount of major versions to reflect all possible combinations of all major versions (cartesian product).

Lets just take the PSR-11 + PSR-6 example, we already would have 6 major versions around because PSR-11 has 2 major versions and PSR-6 has 3 major versions:

- psr/cache 1.x + psr/container 1.x
- psr/cache 1.x + psr/container 2.x
- psr/cache 2.x + psr/container 1.x
- psr/cache 2.x + psr/container 2.x
- psr/cache 3.x + psr/container 1.x
- psr/cache 3.x + psr/container 2.x

And these are only 2 packages. I lost track on the current progress, but there will be more major versions in the future and thus the amount of major versions for the extension will grow (and with that, the confusion for upstream projects, maintainers, etc.).

We highly recommend to use composer to install the PSR standards per package in the version the upstream project can work with.
**Do not use the `psr` extension**

Signed-off-by: Maximilian Bösing <[email protected]>
Updates the CHANGELOG.md to set the release date.
Updates the CHANGELOG.md file to add a changelog entry for a new 3.11.3 version.
…amespaces which contains class name

Signed-off-by: Ádám Bálint <[email protected]>
Fixed namespace generation in `FactoryCreator` utility
Updates the CHANGELOG.md to set the release date.
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs some adjusting of conflicts (doing it now)

@Ocramius Ocramius added the Bug Something isn't working label Jun 13, 2022
@Ocramius Ocramius added this to the 3.12.0 milestone Jun 13, 2022
@Ocramius Ocramius self-assigned this Jun 13, 2022
…-up-into-3.12.x_xqXSdXDX-3.12.x-conflict-resolution
@Ocramius Ocramius merged commit 05ac4b1 into 3.12.x Jun 13, 2022
@Ocramius Ocramius deleted the 3.11.x-merge-up-into-3.12.x_xqXSdXDX branch June 13, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants