Fix issues with Composer package validation #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evidently, a replace rule automatically marks a package as a conflict, so defining both is redundant and causes Packagist not to list the branch/release. Additionally, this version removes the dependency on container-interop in the require section, since it provides that dependency itself. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Evidently, a replace rule automatically marks a package as a conflict, so defining both is redundant and causes Packagist not to list the branch/release.
Additionally, this version removes the dependency on container-interop in the require section, since it provides that dependency itself.
Verified by running
composer validatelocally; not sure why it wasn't flagged on previous CI runs.