-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5 : Handle Response::sendHeaders() to not silently returns when header already sent #41
Conversation
…rns when header already sent Signed-off-by: Abdul Malik Ikhsan <[email protected]>
travis build green 🎉 |
Given the stability of this library, I'm not sure if introducing this BC break at this point will be worth it though 🤔 |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
travis build green 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! I've marked a few changes for you to make. Additionally, please add some documentation in the docs/book/response.md
file around this; when you do, please make sure you indicate it's "since 2.13.0".
…nd make expectException* message call immediate call before actual method call Signed-off-by: Abdul Malik Ikhsan <[email protected]>
travis build green 🎉 |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@weierophinney I've added documentation for it. |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Abdul Malik Ikhsan <[email protected]>
c42c20d
to
8334a2e
Compare
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Abdul Malik Ikhsan [email protected]
Description
Fixes #5 Handle Response::sendHeaders() to not silently returns when header already sent