Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend\Http\Response\PhpEnvironment#sendHeaders() silently returns - should scream and burn and demand for human sacrifices instead #5

Closed
weierophinney opened this issue Dec 31, 2019 · 1 comment
Labels
BC Break Bug Something isn't working
Milestone

Comments

@weierophinney
Copy link
Member

https://github.com/zendframework/zend-http/blob/b382c6e068a2d9c87b7cf0dfe78c6dd19e4ff197/src/PhpEnvironment/Response.php#L84

To reproduce (sorry if I couldn't do it myself right away - needs a @runInSeparateProcess test):

$response = new \Zend\Http\Response\PhpEnvironment();

echo 'foo;
ob_flush();

// expect an exception here
$response->sendHeaders();

Originally posted by @Ocramius at zendframework/zend-http#138

@samsonasik
Copy link
Member

@Ocramius I created PR #41 for it.

@weierophinney weierophinney added this to the 2.13.0 milestone Aug 18, 2020
weierophinney added a commit that referenced this issue Aug 18, 2020
Fixes #5 : Handle Response::sendHeaders() to not silently returns when header already sent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants